Skip to content

Fix missing SelectMenu Type, ChannelTypes, DefaultValues in ComponentBuilder#3186

Merged
Misha-133 merged 1 commit intodiscord-net:devfrom
OMEGA3065:dev
Sep 13, 2025
Merged

Fix missing SelectMenu Type, ChannelTypes, DefaultValues in ComponentBuilder#3186
Misha-133 merged 1 commit intodiscord-net:devfrom
OMEGA3065:dev

Conversation

@OMEGA3065
Copy link
Copy Markdown
Contributor

Description

Fixes a bug where doing ComponentBuilder:AddComponent (called by ComponentBuilder:FromComponents which is in turn used when doing interaction.ModifyOriginalResponseAsync) will void some of the properties of a SelectMenu.

Changes

  • Added some missing SelectMenu properties in the ComponentBuilder:AddComponent that would result in the new component missing some key values, like for instance the selection of whether it is a UserSelect, MentionSelect or other.
  • Added the Type to an empty constructor in MessageComponentConverter.ReadJson since it would be expected that a UserSelect isn't the same thing as a ChannelSelect.

Related Issues

None, I did make a post to the #help channel in the discord, but I got no response back within the first 24 hrs.

@Misha-133 Misha-133 enabled auto-merge (squash) September 13, 2025 17:14
@Misha-133 Misha-133 merged commit 8883596 into discord-net:dev Sep 13, 2025
2 checks passed
mkaraki pushed a commit to mkaraki/Diffcord that referenced this pull request Apr 1, 2026
Updated [Discord.Net](https://github.com/discord-net/Discord.Net) from
3.18.0 to 3.19.1.

<details>
<summary>Release notes</summary>

_Sourced from [Discord.Net's
releases](https://github.com/discord-net/Discord.Net/releases)._

## 3.19.1

## [3.19.1] - 2026-03-12
This release fixes some issues with libdave as well as adds some missing
API coverage

### Added
- #​3226 Added Community Invites (9bb0e06)
- #​3229 Added Modal radio/checkbox groups & checkboxes (c0fbefe)
- #​3246 Added support for enhanced role colors ( gradient and
holograpic ) (3e8aacf)
### Fixed
- #​3224 Fixed forum CreatePostWithFileAsync with V2 components
(0449e53)
- #​3231 Derived types of ContextCommandAttribute should be able to
specify a RunMode in their constructor. (8556416)
- #​3244 Fixed libdave audio issues for users joining/leaving vc, as
well as empty vcs (1c534fa)
- #​3249 GetComponentIds missing accessory component in sections
(66c7409)
### Misc
- #​3219 Document new modal components (8333e4b)
- #​3245 Patch modal docs oversights (c0bde1c)
- #​3248 Replace a deprecated Exception in the slash command guide
(f5b9d3a)

## 3.19.0

## [3.19.0] - 2025-03-02

This release introduces [libdave](https://github.com/discord/libdave)
support as well as some fixes and misc. additions

### Added
- #​3241 libdave support (#​3222) (0195461)
- #​3242 Added voice close code `4017` (0ea1dcb)
- #​3221 Added missing channel types for selects in interaction
framework (9c1db3f)
- #​3228 Added `BypassSlowmode` permission (0dea5bb)
- #​3233 Added optional id parameter to ThumbnailBuilder constructor
(09e0fdb)
- #​3234 Added optional id parameter to SeparatorBuilder constructor
(c3a30db)
- #​3235 Added constructor for SectionBuilder with id (b169a11)
- #​3236 Added constructor for ActionRowBuilder with id (e05e849)
- #​3237 Added overloaded constructor to ContainerBuilder (e3cb507)
- #​3238 Added overloaded constructor with id to MediaGalleryBuilder
(16ea091)

### Fixed
- #​3221 Fix Modal write invocation without instance (9c1db3f)

### Misc
- #​3240 Removed unnecessary checks for content in `ModifyAsync`
(414b1a0)

## 3.19.0-beta.1

## [3.19.0-beta.1] - 2026-01-03
This beta release brings some large much wanted updates to DNet, with
the most notable change being support for more components in modals.
Thanks to contributors, DNet's voice implementation has been updated to
support newer encryption modes and voice gateway API versions, although
there's still no `libdave` e2ee support, which is *hopefully* on its
way.

Aside from the new features and fixes, DNet drops legacy SDK versions
and switches to modern .NET targets (.NET8+). This also comes alongside
the switch to `System.Linq.AsyncEnumerable` from
`System.Interactive.Async`

### Added
- #​3172 Modal refactoring & select menu support (a476014)
- #​3178 Add  `PinMessages` permission (5273f1d)
- #​3183 Update voice API to version 8 (927c905)
- #​3189 Modal Select Components Support for IF (e8c5436)
- #​3196 Add modify current guild member support (80fbbc2)
- #​3198 Get Archived thread calls on text channels (ca6c9bc)
- #​3199 Add select menu `IsRequired` property and fix usage of
`DefaultValues` (0aff637)
- #​3200 Add net10.0 build target, update deps (f205bba)
- #​3193 Remove unsupported SDK targets (5ca29fd))
- #​3195 Add `GetRoleUserCounts` REST method (dade9b2)
- #​3207 Added UnknownComponent classes, and support to
MessageComponentConverter and MessageComponentExtensions (ad8182f)
- #​3209 Modal Components v2 Single-select Typeconverters, Rest, and
Patches (1e27c99)
  
### Fixed
- #​3167 Incorrect casts in the legacy component builder (958d286)
- #​3173 Remove voice gateway port stripping (0b078d7)
- #​3174 Fix duplicated flag value in ActivityProperties enum (ebc7db8)
- #​3186 Fix missing SelectMenu Type, ChannelTypes, DefaultValues in
ComponentBuilder.AddComponent (8883596)
- #​3190 Fix voice receiving (a468e18)
- #​3192 fixed error on changing role icon/emoji to an image. (06510e1)
- #​3204 Fix user status update when speaking (11a56bc)
- #​3206 Fix AutocompleteResult.Value having no length limit (161a91e)
- #​3210 Fix NRE in Rest Interaction Guild User Resolution (fd6e3ad)
- #​3218 fix modal text display constructor initialization (86b885b)
- #​3197 Correct `IUserMessage.ModifyAsync` precondition expression
(8668092)

### Misc
- #​3169 Make ParameterChoice constructor public (9cb6ffd)
- #​3171 Bump guild batch limit to 200 (fc0712d)
- #​3176 Add better json type exception (ae6e7d5)
- #​3177 Make Cacheable constructors public (e61eb51
- #​3216 Improve .NET 9.0+ locking performance (4e95dd7)
- #​3217 Switch lock backport package to #if defs instead (b386a0e)

## New Contributors
* @​OMEGA3065 made their first contribution in
discord-net/Discord.Net#3186
* @​codekm92 made their first contribution in
discord-net/Discord.Net#3192
* @​HEJOK254 made their first contribution in
discord-net/Discord.Net#3206
* @​tg2k made their first contribution in
discord-net/Discord.Net#3207
* @​MarkCiliaVincenti made their first contribution in
discord-net/Discord.Net#3216

**Full Changelog**:
discord-net/Discord.Net@3.18.0...3.19.0-beta.1

Commits viewable in [compare
view](discord-net/Discord.Net@3.18.0...3.19.1).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Discord.Net&package-manager=nuget&previous-version=3.18.0&new-version=3.19.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants